Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

electromagnetic (EM) wave propagation #1225

Closed
wants to merge 3 commits into from
Closed

Conversation

cmorency1
Copy link

Added/edited files to handle EM wave propagation simulations
Created an EXAMPLES
Updated Par_files in EXAMPLES/

Copy link

codecov bot commented May 22, 2024

Codecov Report

Attention: Patch coverage is 14.11411% with 572 lines in your changes are missing coverage. Please review.

Project coverage is 36.34%. Comparing base (76f4636) to head (09d698a).
Report is 1 commits behind head on devel.

Files Patch % Lines
src/specfem2D/compute_stacey_electromagnetic.f90 0.00% 197 Missing ⚠️
src/specfem2D/compute_forces_electromagnetic.F90 0.00% 91 Missing ⚠️
src/specfem2D/get_MPI.F90 16.94% 49 Missing ⚠️
...em2D/compute_forces_electromagnetic_conduction.F90 0.00% 46 Missing ⚠️
.../specfem2D/compute_add_sources_electromagnetic.f90 0.00% 36 Missing ⚠️
src/shared/read_material_table.f90 32.50% 27 Missing ⚠️
src/specfem2D/assemble_MPI.F90 0.00% 26 Missing ⚠️
.../specfem2D/compute_attenuation_electromagnetic.f90 0.00% 24 Missing ⚠️
src/specfem2D/check_grid.F90 67.14% 23 Missing ⚠️
...compute_forces_electromagnetic_calling_routine.F90 0.00% 16 Missing ⚠️
... and 5 more
Additional details and impacted files
@@             Coverage Diff             @@
##            devel    #1225       +/-   ##
===========================================
- Coverage   54.63%   36.34%   -18.30%     
===========================================
  Files         164      171        +7     
  Lines       30233    30684      +451     
===========================================
- Hits        16519    11153     -5366     
- Misses      13714    19531     +5817     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@danielpeter danielpeter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great, well done! this is going to be an exiting feature in the package.

there are only 2 little things to fix: one with the Par_file changes (which is changing comments, more than actually needed), and one with an issue of the parallel code compilation (in file src/specfem2D/assemble_MPI.f90).

Please see the review comments and re-submit the PR when fixed.

#
# Simulation input parameters
# simulation input parameters
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the current Par_file format uses capital "Simulation" and has some more verbose comments (see for example after ATTENUATION_f0_REFERENCE) -> please base the change of all Par_files from a current Par_file and only add the two new parameters for permittivity and conductivity.

do i = 1, nibool_interfaces_electromagnetic(iinterface)
ipoin = ipoin + 1
iglob = ibool_interfaces_electromagnetic(i,iinterface)
buffer_send_faces_scalar(ipoin,iinterface) = array_val5(idim,iglob)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the array array_val5 has not been defined yet, so this will fail code compilation for the parallel version (WITH_MPI) - please fix this and re-submit the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants