Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Plugin's classloader always SimplePluginClassLoader #62

Merged
merged 3 commits into from
Dec 3, 2023

Conversation

huanmeng-qwq
Copy link
Collaborator

KookBC Pull Request

Plugin的ClassLoader将永远是SimplePluginClassLoader,在这之前在mixin模式下它是LaunchClassLoader

KookBC 程序的漏洞修复

如果您的 Fork 修复了某个 Issue 所描述的问题,请在这里提及那个 Issue 。

#61

@huanmeng-qwq huanmeng-qwq linked an issue Nov 27, 2023 that may be closed by this pull request
@SNWCreations
Copy link
Owner

请进行测试,以验证修改满足原 Issue 的要求。
我将在晚上下班后处理。

@huanmeng-qwq
Copy link
Collaborator Author

测试结果:双模式均可正常启动并加载插件,所有模式下的插件的classloader均为SimplePluginClassLoader,注册的ConfigurationSerializable在classloader#close时unregister

@SNWCreations
Copy link
Owner

通过。

@SNWCreations SNWCreations removed the request for review from xiaoACE6716 December 3, 2023 03:28
Copy link
Owner

@SNWCreations SNWCreations left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK

@SNWCreations SNWCreations merged commit ee8f456 into dev Dec 3, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

禁用插件时未注销其注册的YAML序列化器
2 participants