Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: (CXSPA-8813) B2C button My Store not properly styled #19528

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

fix: (CXSPA-8813) B2C button My Store not properly styled #19528

wants to merge 3 commits into from
+107 −38

Conversation

StanislavSukhanov
Copy link
Contributor

@StanislavSukhanov StanislavSukhanov self-assigned this Nov 12, 2024
@StanislavSukhanov StanislavSukhanov requested a review from a team as a code owner November 12, 2024 14:12
@github-actions github-actions bot marked this pull request as draft November 12, 2024 14:12
@StanislavSukhanov StanislavSukhanov marked this pull request as ready for review November 12, 2024 14:13
@cypress Cypress
Copy link

cypress bot commented Nov 12, 2024 •
edited
Loading

spartacus    Run #45759

Run Properties:  status check passed Passed #45759  •  git commit e511c9076f ℹ️: Merge 81b14a23d9c803a8974310d32411b11a33b35db4 into 7881686d8630500b6e0fafdfc68e...
Project spartacus
Branch Review feature/CXSPA-8813-B2C-button-My-Store-not-properly-styled
Run status status check passed Passed #45759
Run duration 04m 56s
Commit git commit e511c9076f ℹ️: Merge 81b14a23d9c803a8974310d32411b11a33b35db4 into 7881686d8630500b6e0fafdfc68e...
Committer Stanislav Sukhanov
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 3
Tests that did not run due to a developer annotating a test with .skip  Pending 2
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 125
View all changes introduced in this branch ↗︎

@StanislavSukhanov StanislavSukhanov force-pushed the feature/CXSPA-8813-B2C-button-My-Store-not-properly-styled branch from 1f57a15 to 014b3d8 Compare November 13, 2024 18:44
@github-actions github-actions bot marked this pull request as draft November 13, 2024 18:44
@StanislavSukhanov StanislavSukhanov marked this pull request as ready for review November 13, 2024 18:44
@github-actions github-actions bot marked this pull request as draft November 14, 2024 10:56
@StanislavSukhanov StanislavSukhanov marked this pull request as ready for review November 14, 2024 10:56
@StanislavSukhanov StanislavSukhanov force-pushed the feature/CXSPA-8813-B2C-button-My-Store-not-properly-styled branch from b2ebecb to 81b14a2 Compare November 14, 2024 11:55
@github-actions github-actions bot marked this pull request as draft November 14, 2024 11:55
@StanislavSukhanov StanislavSukhanov marked this pull request as ready for review November 14, 2024 11:56
@developpeurweb
Copy link
Contributor

@StanislavSukhanov can you please look into the following issues:

  • While testing with keyboard-only navigation, the link element gets skipped from the Tabbing sequence (focus jumps from "Home" breadcrumb to "Search" field).
  • When activating the link with the mouse, there is dark background, please remove it and leave as normal link behaviour.
  • Add an aria-label to the link to announce screen reader users that it will open in a new window, similar to screenshot below
    aria label opens in new windows

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Zeyber Zeyber Zeyber approved these changes

@Pio-Bar Pio-Bar Awaiting requested review from Pio-Bar

Assignees

@StanislavSukhanov StanislavSukhanov

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@StanislavSukhanov @developpeurweb @Zeyber