add instance external name to credentials secret (#272)

SAP · Mar 16, 2023 · 8efd50e · 8efd50e
1 parent a3f26b9
commit 8efd50e
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/controllers/servicebinding_controller.go b/controllers/servicebinding_controller.go
@@ -700,6 +700,7 @@ func (r *ServiceBindingReconciler) addInstanceInfo(ctx context.Context, binding
 	}
 
 	credentialsMap["instance_name"] = []byte(binding.Spec.ServiceInstanceName)
+	credentialsMap["instance_external_name"] = []byte(instance.Spec.ExternalName)
 	credentialsMap["instance_guid"] = []byte(instance.Status.InstanceID)
 	credentialsMap["plan"] = []byte(instance.Spec.ServicePlanName)
 	credentialsMap["label"] = []byte(instance.Spec.ServiceOfferingName)

diff --git a/controllers/servicebinding_controller_test.go b/controllers/servicebinding_controller_test.go
@@ -160,7 +160,7 @@ var _ = Describe("ServiceBinding controller", func() {
 	}
 
 	JustBeforeEach(func() {
-		createdInstance = createInstance(context.Background(), instanceName, bindingTestNamespace, "")
+		createdInstance = createInstance(context.Background(), instanceName, bindingTestNamespace, instanceName+"-external")
 	})
 
 	BeforeEach(func() {
@@ -379,6 +379,8 @@ var _ = Describe("ServiceBinding controller", func() {
 					bindingSecret := getSecret(ctx, createdBinding.Spec.SecretName, createdBinding.Namespace, true)
 					validateSecretData(bindingSecret, "secret_key", "secret_value")
 					validateSecretData(bindingSecret, "escaped", `{"escaped_key":"escaped_val"}`)
+					validateSecretData(bindingSecret, "instance_external_name", createdInstance.Spec.ExternalName)
+					validateSecretData(bindingSecret, "instance_name", createdInstance.Name)
 					validateInstanceInfo(bindingSecret)
 					credentialProperties := []SecretMetadataProperty{
 						{