fix: v2 qa for semantic date range version limitation #2561
+137
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 1d99684 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
voicis
reviewed
Nov 13, 2024
| const version = await getUi5Version(); | ||
| const isUI5VersionNotSupported = | ||
| isLowerThanMinimalUi5Version(version, { major: 1, minor: 128 }) || | ||
| (version.major === 1 && (version.minor === 96 || version.minor === 108 || version.minor === 120)); |
There was a problem hiding this comment.
Shouldn't 1.96, 1.108 and 1.120 should be also supported? Currently it looks like all the versions below 1.128 are not supported.
There was a problem hiding this comment.
adapted the logic with test (with exact version 1.96). the condition was not handling it correctly.
|
voicis
approved these changes
Nov 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
restrict the 'Semantic Date Range" in filter bar quick-action for certain UI5 versions which are not supported for V2 application.