Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cf-deploy-config-writer): cleanup based on local testing when using headless #2546

Open
wants to merge 11 commits into
base: main
Choose a base branch
from

Conversation

longieirl
Copy link
Contributor

@longieirl longieirl commented Nov 8, 2024

Fix for #2007

  • updated snapshots to reflect latest changes
  • mbt should only be added if it the package.json is updated scripts that are dependent on it, it was being added regardless before
  • tested locally against headless flow in deployment-generator
  • cleanup readme

@longieirl longieirl self-assigned this Nov 8, 2024
Copy link

changeset-bot bot commented Nov 8, 2024

🦋 Changeset detected

Latest commit: 5b8c6ea

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sap-ux/cf-deploy-config-writer Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@longieirl longieirl marked this pull request as ready for review November 8, 2024 15:20
cianmSAP
cianmSAP previously approved these changes Nov 12, 2024
Copy link
Contributor

@cianmSAP cianmSAP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Upates look good
I've not tested locally
Tests to cover

Copy link

sonarcloud bot commented Nov 14, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants