Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CHECK_PREFER_IS_NOT: Exempt predicative method calls #599

Merged
merged 7 commits into from
Aug 16, 2023
Merged

CHECK_PREFER_IS_NOT: Exempt predicative method calls #599

merged 7 commits into from
Aug 16, 2023

Conversation

ConjuringCoffee
Copy link
Contributor

Fixes #362

@ConjuringCoffee ConjuringCoffee requested a review from a team as a code owner August 11, 2023 08:21
@ConjuringCoffee ConjuringCoffee marked this pull request as draft August 11, 2023 10:25
@ConjuringCoffee ConjuringCoffee marked this pull request as ready for review August 11, 2023 11:38
@ConjuringCoffee
Copy link
Contributor Author

Over the weekend I found another case that wasn't covered previously: IF NEW lcl_object( )->is_active( ).

bjoern-jueliger-sap
bjoern-jueliger-sap approved these changes Aug 16, 2023
View reviewed changes
Copy link
Member

@bjoern-jueliger-sap bjoern-jueliger-sap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me and works fine on all my weird examples now - thanks for your effort!

@bjoern-jueliger-sap bjoern-jueliger-sap merged commit b45a99b into SAP:master Aug 16, 2023
4 checks passed
@ConjuringCoffee ConjuringCoffee deleted the prefer-is-not-predicative branch August 16, 2023 10:22
@ConjuringCoffee ConjuringCoffee mentioned this pull request Aug 16, 2023
Merged
@larsip larsip mentioned this pull request Feb 7, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bjoern-jueliger-sap bjoern-jueliger-sap bjoern-jueliger-sap approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

false positives: Prefer IS NOT to NOT IS
2 participants
@ConjuringCoffee @bjoern-jueliger-sap