This repository has been archived by the owner on Oct 8, 2020. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding entity resolution feature to SANSA-ML. #24
base: develop
Are you sure you want to change the base?
Adding entity resolution feature to SANSA-ML. #24
Changes from 1 commit
f323e7b
684cc6d
26c9e5c
5b876d3
5e5aace
24caf70
4f9c7fe
6e92b0d
70ce1b7
ee7120c
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same here. We should remove any hard-coded code.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see that it is quite static? What will happen if there is another dataset to be used? Can we add them to a specific configuration file? or even an input (parameter, file) which allows users to define their predicates they want to filter them out. We could make it even more extensible by allowing users to add them as RDF triples (we could define as simple RDF graph which contains these predicates to filter out, but this is optional - the RDF graph and not moving them out of the hard-coded variable).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Again, this number is quite static and we should find a way how to define it (if it is needed).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No
println
s statements on API. We should move them to SANSA-Examples.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do the same for the rest as well.