Add a function for underline handling in literal/src/float.rs .
#122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youknowone
approved these changes
Jul 23, 2024
Comment on lines
+59
to
+61
| // Use custom function for underline handling for now. | ||
| // For further information see https://github.com/Alexhuszagh/rust-lexical/issues/96. | ||
| let stripped = strip_underlines(literal)?; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
This PR is related to PR #5356 in the RustPython repo. While investigating the
NumberFormatBuilderI noticed that even though the flagfraction_consecutive_digit_separatoris set tofalsethe parser processed the bytes as if it was set totrue. This observation was also made in issue #96 in therust-lexicalrepo.