Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect f-string parsing #112

Merged
merged 4 commits into from
Jan 23, 2024
Merged

Incorrect f-string parsing #112

merged 4 commits into from
Jan 23, 2024

Conversation

yt2b
Copy link
Contributor

@yt2b yt2b commented Jan 20, 2024

#88
I've fixed to parse escaped brackets correctly.

@youknowone
Copy link
Member

Thank you. Could you also open a PR to RustPython/RustPython using this PR to ensure it doesn't break RustPython build?

@yt2b yt2b mentioned this pull request Jan 22, 2024
Closed
@yt2b
Copy link
Contributor Author

yt2b commented Jan 22, 2024

I've opened PR to ensure that RustPython builds don't fail.
CI has passed.
RustPython/RustPython#5153

youknowone
youknowone approved these changes Jan 23, 2024
View reviewed changes
Copy link
Member

@youknowone youknowone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much. If you are interested in fixing parser bugs, backporting Ruff's python parser to RustPython would be a one-shot solution

@youknowone youknowone merged commit 9ce55ae into RustPython:main Jan 23, 2024
3 checks passed
@yt2b yt2b deleted the escaped_brackets branch January 23, 2024 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@youknowone youknowone youknowone approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yt2b @youknowone