Skip to content

Commit

Permalink
Add Customized trait for CSHAKE. Use new customized in tests.
Browse files Browse the repository at this point in the history
  • Loading branch information
sylvainpelissier committed May 5, 2024
1 parent 1f79203 commit 44153da
Show file tree
Hide file tree
Showing 3 changed files with 14 additions and 21 deletions.
2 changes: 1 addition & 1 deletion sha3/src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
#![forbid(unsafe_code)]
#![warn(missing_docs, rust_2018_idioms)]

pub use digest::{self, Digest};
pub use digest::{self, CustomizedInit, Digest};

use core::fmt;
use digest::{
Expand Down
7 changes: 7 additions & 0 deletions sha3/src/macros.rs
Original file line number Diff line number Diff line change
Expand Up @@ -613,5 +613,12 @@ macro_rules! impl_cshake {

#[cfg(feature = "zeroize")]
impl ZeroizeOnDrop for $reader {}

impl CustomizedInit for $name {
#[inline]
fn new_customized(customization: &[u8]) -> Self {
Self::new(customization)
}
}
};
}
26 changes: 6 additions & 20 deletions sha3/tests/cshake.rs
Original file line number Diff line number Diff line change
Expand Up @@ -88,17 +88,17 @@ where
}

macro_rules! new_cshake_test {
($name:ident, $test_name:expr, $hasher:ty, $hasher_core:ty, $test_func:ident $(,)?) => {
($name:ident, $test_name:expr, $hasher:ty, $test_func:ident $(,)?) => {
#[test]
fn $name() {
use digest::dev::blobby::Blob3Iterator;
let data = include_bytes!(concat!("data/", $test_name, ".blb"));

for (i, row) in Blob3Iterator::new(data).unwrap().enumerate() {
let [customization, input, output] = row.unwrap();
if let Some(desc) = $test_func(input, output, || {
<$hasher>::from_core(<$hasher_core>::new(customization))
}) {
if let Some(desc) =
$test_func(input, output, || <$hasher>::new_customized(customization))
{
panic!(
"\n\
Failed test №{}: {}\n\
Expand All @@ -117,29 +117,15 @@ new_cshake_test!(
cshake128_reset,
"cshake128",
sha3::CShake128,
sha3::CShake128Core,
cshake_reset_test
);
#[cfg(feature = "reset")]
new_cshake_test!(
cshake256_reset,
"cshake256",
sha3::CShake256,
sha3::CShake256Core,
cshake_reset_test
);

new_cshake_test!(
cshake128,
"cshake128",
sha3::CShake128,
sha3::CShake128Core,
cshake_test
);
new_cshake_test!(
cshake256,
"cshake256",
sha3::CShake256,
sha3::CShake256Core,
cshake_test
);
new_cshake_test!(cshake128, "cshake128", sha3::CShake128, cshake_test);
new_cshake_test!(cshake256, "cshake256", sha3::CShake256, cshake_test);

0 comments on commit 44153da

Please sign in to comment.