Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

const-oid/v0.9.5 backporting rfc8410 OIDs #1182

Merged
merged 3 commits into from
Aug 8, 2023

Conversation

flihp
Copy link
Contributor

@flihp flihp commented Aug 2, 2023

backport rfc8410 OIDs into new release from const-oid/v0.9 branch following form from #1139

flihp and others added 2 commits August 2, 2023 10:16
This includes: Ed25519, Ed448, X25519 and X448.

This RFC & the relevant OIDs aren't included in the IANA LDAP CSV. The
full text of the RFC is included as an alternative.
Backport release for RFC8410 support from RustCrypto#867
@flihp
Copy link
Contributor Author

flihp commented Aug 2, 2023

The workspace clippy check is failing here like it did in #1139: #1139 (comment). I'm happy to help fix that up if necessary.

@tarcieri
Copy link
Member

tarcieri commented Aug 6, 2023

Looks like an MSRV-related failure. You can probably avoid it by running clippy without the arbitrary feature.

@baloo
Copy link
Member

baloo commented Aug 7, 2023

I also ignored the clippy error in #1139. Speaking personally, I'm fine with letting it fail.
If you're alright with that @tarcieri I'll merge that (bumping the date) and publish the release.

Including `--all-features` builds const-oid with the `arbitrary` feature
which has dependencies incompatible with the current MSRV.
@flihp
Copy link
Contributor Author

flihp commented Aug 8, 2023

This PR has been updated with the workaround suggested by @tarcieri. I've also created a new issue (#1194) to describe the root cause and make the info a bit more visible.

@tarcieri tarcieri merged commit 0f7974c into RustCrypto:const-oid/v0.9 Aug 8, 2023
123 checks passed
tarcieri added a commit that referenced this pull request Aug 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants