Remove default WiFi configuration in network_only payload #253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Trailing whitespace removed
Remove the default wifi configuration from the network_only payload, in favor of pulling that information from setup.cfg.
Remove the default WiFi configuration in network_only payload
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the network_only payload overrides setup.cfg for WiFi options. Though an excellent demonstration of the payload priority, it has repeatedly been a source of issues (#234, #205, #186, #156, #98, #96) and simply isn't user friendly.
Given that network_only payload is the default selected payload and will most likely be used when doing initial configuration, I suggest we remove the override and replace it with a message indicating the ability to make the changes if the user wishes. Though this will not solve the issue of users not knowing about the payload setting priority (as the user will still encounter it when eventually switching to another payload), it at least delays it, giving the user a better chance of coming across it themselves before submitting an issue. Furthermore, it makes network_only a better payload for use in basic setup.
More obvious documentation of the payload priority is of course needed as well, this is just a first step.