Tuning system glitches and shortcomings

[ohlidalp]

Glitches:

• FlexbodyDebugUI option "hide other" doesn't work right now: https://discord.com/channels/136544456244461568/189904947649708032/1204854455737262120
• Texture with the same name interferes between mods (even if they are in separate ZIPs) https://discord.com/channels/136544456244461568/189904947649708032/1204238031968673823 - fixed in 04fb5da
• crash when 2 addonparts tweak the same node, see below.
• Flat files directly under 'mods/' cannot be loaded - https://discord.com/channels/136544456244461568/189904947649708032/1211009740688199730
• Saved tuneups are not filtered for current actor if the actor has no GUID, all show up at once: https://discord.com/channels/136544456244461568/189904947649708032/1232459506714280078 - fixed by adding 'filename' directive to .tuneup file, allowing to filter by filename.

Minor enhancements:

• add addonpart_unwanted_exhaust https://discord.com/channels/136544456244461568/189904947649708032/1204918739200507934 - should be minor enough
• Leftover points from the original PR: Created vehicle tuning GUI using new .addonpart mod type #3096 (comment)
• Filename matching is much needed: https://discord.com/channels/136544456244461568/189904947649708032/1207163070170927195

[CuriousMike56]

MV4S_SuspensionMods.zip
Apply two addons (any suspension mods) that change the same nodes -> crash. Ideally the game should display an error if conflicting parts (wheels, node/prop/flexbody tweaks) are installed.

[Miner34dev]

Ideally the game should display an error if conflicting parts (wheels, node/prop/flexbody tweaks) are installed.

I was thinking about another solution... What about addon categories? Inside the addon parts you could add some drop down menus, Which should allow to only use one of the parts in the same category at the same time.

[CuriousMike56]

In addition, the tuning menu has MP specific bugs:

• No updates to RoRNet, other players can't see applied addons.
• Applying addons has a chance of your vehicle becoming stuck at map origin (0,0,0) for other players
• Applying any addon reloads the vehicle, the server treats this as if you spawned a new vehicle. This can trigger the spawn spam protection if enabled.
  One time the spam protection kicked me but also crashed all other players on the server. Have yet to reproduce.

Simplest workaround for now is to just disable the tuning menu when playing MP.

[Miner34dev]

Applying any addon reloads the vehicle, the server treats this as if you spawned a new vehicle. This can trigger the spawn spam protection if enabled.
One time the spam protection kicked me but also crashed all other players on the server. Have yet to reproduce.

Can confirm, the same also happened to me.

[ohlidalp]

I looked into the crash when 2 addonparts tweak the same node. The problem is division by zero, which happens because both axis nodes of a wheel somehow end up having precisely the same coordinates - as result the axis vector is <0,0,0> and you know the rest.

I couldn't figure out why this happens. When 2 tweaks clash on the same node, none of them actually take effect, the orignally logged tweak gets withdrawn. For example (RoR.log):

 ~~~ First tweak is found - added to working tuneup ~~~
 [RoR|Addonpart] INFO: file 'MV4_lowered.addonpart', element 'addonpart_tweak_node': tweaking node 119 with params { x=-1.523, y=0.266, z=-0.695 }

 ~~~ Second tweak is found - the previous one gets withdrawn ~~~
 [RoR|Addonpart] INFO: file 'MV4_rally.addonpart', element 'addonpart_tweak_node': Conflict of tweaks at node '119', addon parts '' and 'MV4_rally.addonpart'

I need to improve the logging - the collision message shows the 2nd addonpart name twice and 1st addonpart name is blank.

UPDATE: Fixed in #3151

[ohlidalp]

@Miner34dev

I was thinking about another solution... What about addon categories? Inside the addon parts you could add some drop down menus, Which should allow to only use one of the parts in the same category at the same time.

For the record, that makes sense but cannot be coded properly. There's no way for the game to figure out the category itself, i.e. suspension nodes cannot be distinguished from any other node. And relying on the addonpart creator to categorize the parts correctly won't fix this issue as inevitably some of them will make mistakes.
@CuriousMike56

[ohlidalp]

Resolved by #3151