Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Texture conflicts between mods #3148

Closed
CuriousMike56 opened this issue Apr 5, 2024 · 2 comments
Closed

Texture conflicts between mods #3148

CuriousMike56 opened this issue Apr 5, 2024 · 2 comments

Comments

@CuriousMike56
Copy link
Collaborator

CuriousMike56 commented Apr 5, 2024

This issue ticket provides additional details to the Texture with the same name interferes between mods (even if they are in separate ZIPs) problem reported in #3122.

To assist with testing, I've created two test mods:
MaterialConflictTestRed.zip
MaterialConflictTestBlue.zip

They are simple cubes, with the center being submeshed (texcoords), left a prop, and right a flexbody. Also features a custom N flare material with the same color.
The submeshed cube material name is CM_TestCubeSubmesh, defined in a .material file. The flare material (CM_TestCubeFlare) is also defined in this file.
Prop and flexbody cube material name is CM_TestCube, defined in the managedmaterials section.
Both versions share the same material and texture names.

In 2022.12, both versions can be spawned without conflict:
screenshot_2024-04-05_18-48-36_1

Now with the introduction of the tuning menu, spawning either version will conflict with the other:

screenshot_2024-04-05_18-49-19_1
screenshot_2024-04-05_18-50-37_1

Submesh, prop, and flexbody cube textures all conflict. Only the flare uses the correct texture.

@ohlidalp
Copy link
Member

ohlidalp commented Apr 7, 2024

Thank you for the test mods, I feel way more confident than if I tried to reproduce all by myself.

The offending commit is 74ed108.

@ohlidalp
Copy link
Member

ohlidalp commented Apr 7, 2024

I accidentally pushed the fix directly without making a PR. But it's pretty straightforward and only tackles the one thing, so I'm confident it doesn't break anything.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants