Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for multiple request matching strategies when processing NOTIFY requests #24

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add support for multiple request matching strategies when processing NOTIFY requests #24

wants to merge 2 commits into from

Commits on Jan 16, 2018

  1. Add request processor 

    This commit introduces a concept of a request processing strategy, which is evaluated against the incoming request. This (collection of) strateg(y/ies) provides a determination mechanism of a request being processed by a SipSession or its children. Thus a user may provide extensions to the SipSession on which inbound requests may be accepted without the need to mutate any parameters, or request event processing mechanisms in SipPhone

This is a derivation of the request matcher, allowing for a more flexible implementation.
    @teles-mami
    teles-mami committed Jan 16, 2018
    Configuration menu
    Copy the full SHA
    30dbcee View commit details
    Browse the repository at this point in the history

  2. Substitute NOTIFY request handling for strategy implementation 

    In order to support extensible request handling, we introduce the RequestProcessor class, which is tasked with executing a sequence of strategies over an inbound request for a SipListener instance. These strategies execute sequentially until one of the strategies accepts the request. If no strategies were executed or the validation fails, the governing SipPhone will return an appropriate error (which indicates that either the event was not recognized or the subscription was orphaned).
    @teles-mami
    teles-mami committed Jan 16, 2018
    Configuration menu
    Copy the full SHA
    525d68c View commit details
    Browse the repository at this point in the history