Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR provides support for Spark 4.0.0 (currently preview2) along with major updates to Jedis (from 3.9 -> 5x) as well as migration to Scala 2.13 and Java 17.
Open Questions
The logic in the
getClusterNodes
changed to reflect the new Jedisconn.clusterShards()
command. While the Unit Tests all pass I am unsure of the correct indexing foridx
. The comment specified that it was for non-master nodes, and thenode.getRole()
returnsmaster
for all nodes which makes sense given everything is running on127.0.0.1
.With that said, I could add an AtomicInteger to ensure the
idx
field has monotonically increasing values but I wanted to understand more about how they are used before moving forwards (hence the WIP status).