Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change caddy sidecar image #1066

Merged
merged 4 commits into from
Oct 28, 2024
Merged

Change caddy sidecar image #1066

merged 4 commits into from
Oct 28, 2024

Conversation

Victoremepunto
Copy link
Contributor

@Victoremepunto Victoremepunto commented Oct 23, 2024 •
edited
Loading

  • use the new crc-caddy-ubi image
  • use default TargetPort value (fix deprecation of FromInt)
  • override command

@Victoremepunto Victoremepunto mentioned this pull request Oct 25, 2024
Merged
adamrdrew
adamrdrew approved these changes Oct 28, 2024
View reviewed changes
Copy link
Contributor

@adamrdrew adamrdrew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me and tests are passing

@Victoremepunto Victoremepunto merged commit efaaafa into RedHatInsights:master Oct 28, 2024
7 of 8 checks passed
@Victoremepunto Victoremepunto deleted the change-caddy-sidecar-image branch October 28, 2024 17:11
@Victoremepunto Victoremepunto restored the change-caddy-sidecar-image branch October 28, 2024 18:11
@Victoremepunto Victoremepunto deleted the change-caddy-sidecar-image branch October 28, 2024 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamrdrew adamrdrew adamrdrew approved these changes

@psav psav psav approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Victoremepunto @psav @adamrdrew