Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(YouTube - Announcements): Remove language parameter of API call #3874

Merged

Conversation

LisoUseInAIKyrios
Copy link
Contributor

@LisoUseInAIKyrios LisoUseInAIKyrios commented Nov 9, 2024

This fixes the runtime error of:

AnnouncementsPatch: java.lang.IllegalArgumentException: Error compiling route [/announcements/latest?tag=youtube], incorrect amount of parameters provided. Expected: 0, provided: 1
 AnnouncementsPatch: 	at app.revanced.extension.youtube.requests.Route.compile(Route.java:23)
 AnnouncementsPatch: 	at app.revanced.extension.youtube.requests.Requester.getConnectionFromRoute(Requester.java:20)
 AnnouncementsPatch: 	at app.revanced.extension.youtube.patches.announcements.requests.AnnouncementsRoutes.getAnnouncementsConnectionFromRoute(AnnouncementsRoutes.java:20)

@oSumAtrIX
Copy link
Member

I had intentionally removed the language query parameter. Currently, there are no plans to translate announcements. It would also need some implementation ideas. For now the query parameter should be removed until we know if and how we want to translate announcements.

@LisoUseInAIKyrios LisoUseInAIKyrios changed the title chore(YouTube - Announcements): Add missing language parameter to announcement api call chore(YouTube - Announcements): Remove language parameter of API call Nov 9, 2024
@LisoUseInAIKyrios LisoUseInAIKyrios merged commit 4363dc5 into ReVanced:dev Nov 9, 2024
1 check passed
@LisoUseInAIKyrios LisoUseInAIKyrios deleted the fix/announcements_parameter branch November 9, 2024 02:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants