Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make getters to element public #14

Merged
merged 1 commit into from
May 17, 2024

Conversation

seemenkina
Copy link
Contributor

Access to intermediate nodes in the tree is required during tree handling . It is not possible to do it directly because the cache is completely private.

Making this function public will solve this problem

fyi @rymnc

Copy link
Contributor

@rymnc rymnc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM,
cc: @curryrasul we need this in zerokit since we're performing intermediate computations in the future subtree sharing strategy, would love a review and new release of pmtree to go with it :)
tia

@curryrasul
Copy link
Collaborator

@rymnc @seemenkina
That makes pmtree implementation too specific for one use-case. In general we don't want a public API for cache and all intermediate stuff ... On the other hand the change is too minor.

In general LGTM, I approve this, but I'd like to listen your thoughts on this @rymnc . Maybe we should create a pmtree fork for Vac, and here we should have it for a general case.

@rymnc
Copy link
Contributor

rymnc commented May 15, 2024

sure, we can do that, is it okay if we publish to crates.io with the name vac-pmtree?

cc: @seemenkina

@rymnc rymnc merged commit ce0211d into Rate-Limiting-Nullifier:main May 17, 2024
1 check passed
rymnc pushed a commit to vacp2p/pmtree that referenced this pull request May 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants