Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: include db.close, error handling and public db field #13

Merged
merged 4 commits into from
Aug 12, 2023
Merged

fix: include db.close, error handling and public db field #13

merged 4 commits into from
Aug 12, 2023

Conversation

rymnc
Copy link
Contributor

@rymnc rymnc commented Aug 8, 2023 •
edited
Loading

This includes a few changes required so that implementers may obtain -

  • better error handling on startup
  • graceful connection closing
  • public db field
  • removes the rln dependency, since we use pmtree as default now.

@rymnc rymnc marked this pull request as ready for review August 8, 2023 08:13
@rymnc rymnc requested a review from curryrasul August 8, 2023 10:12
@rymnc rymnc self-assigned this Aug 8, 2023
curryrasul
curryrasul approved these changes Aug 12, 2023
View reviewed changes
Copy link
Collaborator

@curryrasul curryrasul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @rymnc

@curryrasul curryrasul merged commit 1ddb2ae into Rate-Limiting-Nullifier:main Aug 12, 2023
1 check passed
@rymnc rymnc deleted the pmtree-upstream branch August 12, 2023 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@curryrasul curryrasul curryrasul approved these changes

Assignees

@rymnc rymnc

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rymnc @curryrasul