Skip to content

Commit

Permalink
Merge branch 'aomp-dev' of https://github.com/ROCm-Developer-Tools/aomp
Browse files Browse the repository at this point in the history
… into aomp-dev
  • Loading branch information
gregrodgers committed Apr 12, 2023
2 parents 957bac7 + 878fbf5 commit 5047503
Show file tree
Hide file tree
Showing 9 changed files with 36 additions and 18 deletions.
2 changes: 1 addition & 1 deletion bin/aomp_common_vars
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ ROCM_VERSION=${ROCM_VERSION:-5.3.0}

# Set the AOMP VERSION STRING
AOMP_VERSION=${AOMP_VERSION:-"17.0"}
AOMP_VERSION_MOD=${AOMP_VERSION_MOD:-"1"}
AOMP_VERSION_MOD=${AOMP_VERSION_MOD:-"2"}
AOMP_VERSION_STRING=${AOMP_VERSION_STRING:-"$AOMP_VERSION-$AOMP_VERSION_MOD"}
export AOMP_VERSION_STRING AOMP_VERSION AOMP_VERSION_MOD ROCM_VERSION

Expand Down
2 changes: 1 addition & 1 deletion bin/check_sollve.sh
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@ done
# This log combines all pass/fails from various openmp versions into one file.
# Each test is prefixed with openmp version for clarity.
if [ "$1" == "log" ]; then
date=`date '+%Y-%m-%d'`
date=${BLOG_DATE:-`date '+%Y-%m-%d'`}
base_dir=$AOMP_REPOS_TEST/$AOMP_SOLVV_REPO_NAME
cd $base_dir

Expand Down
2 changes: 1 addition & 1 deletion bin/run_ovo.sh
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ export MAKEFLAGS=-j$HALF_THREADS
./ovo.sh run
./ovo.sh report --summary

date=`date '+%Y-%m-%d'`
date=${BLOG_DATE:-`date '+%Y-%m-%d'`}
if [ "$1" == "log" ]; then
if [ "$2" != "" ]; then
prefix=$2
Expand Down
5 changes: 2 additions & 3 deletions bin/spec-configs/hpc2021/amdgpu_clang.cfg
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ FC_VERSION_OPTION = --version

#preENV_OMP_PROC_BIND=true
MPIRUN_OPTS = --bind-to none #socket # core
submit = timeout 20m mpirun ${MPIRUN_OPTS} -np $ranks gpurun -s $command
submit = timeout -s 9 20m mpirun ${MPIRUN_OPTS} -np $ranks gpurun -s $command

#######################################################################

Expand Down Expand Up @@ -103,7 +103,7 @@ PORTABILITY_LIBS = -lm
#submit = mpirun ${MPIRUN_OPTS} -np $ranks gpurun -s strace -t -e trace=%memory $command
#submit = mpirun ${MPIRUN_OPTS} -np $ranks $command
#submit = timeout 20m mpirun ${MPIRUN_OPTS} -np $ranks $command
submit = timeout 20m mpirun ${MPIRUN_OPTS} -np $ranks gpurun -s $command
submit = timeout -s 9 20m mpirun ${MPIRUN_OPTS} -np $ranks gpurun -s $command
OPTIMIZE += -fopenmp -fopenmp-targets=amdgcn-amd-amdhsa -Xopenmp-target=amdgcn-amd-amdhsa -march=%{gputype}
OPTIMIZE += -fopenmp-target-xteam-reduction-blocksize=128
# OPTIMIZE += -mcode-object-version=5
Expand Down Expand Up @@ -135,4 +135,3 @@ PORTABILITY_LIBS = -lm
default=peak=default:
basepeak=1

__HASH__
15 changes: 10 additions & 5 deletions bin/spec-configs/hpc2021/rocm-5.4/amdgpu_clang.cfg
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ FC_VERSION_OPTION = --version

#preENV_OMP_PROC_BIND=true
MPIRUN_OPTS = --bind-to none #socket # core
submit = mpirun ${MPIRUN_OPTS} -np $ranks gpurun $command
submit = timeout 20m mpirun ${MPIRUN_OPTS} -np $ranks gpurun -s $command

#######################################################################

Expand Down Expand Up @@ -102,15 +102,20 @@ PORTABILITY_LIBS = -lm
#submit = mpirun ${MPIRUN_OPTS} -np $ranks $command
#submit = mpirun ${MPIRUN_OPTS} -np $ranks gpurun -s strace -t -e trace=%memory $command
#submit = mpirun ${MPIRUN_OPTS} -np $ranks $command
submit = mpirun ${MPIRUN_OPTS} -np $ranks gpurun -s $command
#submit = timeout 20m mpirun ${MPIRUN_OPTS} -np $ranks $command
submit = timeout -s 9 20m mpirun ${MPIRUN_OPTS} -np $ranks gpurun -s $command
OPTIMIZE += -fopenmp -fopenmp-targets=amdgcn-amd-amdhsa -Xopenmp-target=amdgcn-amd-amdhsa -march=%{gputype}
# OPTIMIZE += -mcode-object-version=5

505.lbm_t:
505.lbm_t,605.lbm_s,705.lbm_m,805.lbm_l:
OPTIMIZE += -fno-openmp-target-ignore-env-vars
513.soma_t,613.soma_s:
PORTABILITY += -DSPEC_NO_VAR_ARRAY_REDUCE
519.clvleaf_t:
FOPTIMIZE += -Mx,201,2 # workaround for map copy issue
519.clvleaf_t,619.clvleaf_s,719.clvleaf_m,819.clvleaf_l:
FOPTIMIZE += -Mx,201,2 # workaround for map copy issue
# FOPTIMIZE += -Mx,234,100 #
534.hpgmgfv_t:
COPTIMIZE += -fno-openmp-assume-no-nested-parallelism

%endif

Expand Down
17 changes: 11 additions & 6 deletions bin/spec-configs/hpc2021/rocm-5.5/amdgpu_clang.cfg
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ FC_VERSION_OPTION = --version

#preENV_OMP_PROC_BIND=true
MPIRUN_OPTS = --bind-to none #socket # core
submit = mpirun ${MPIRUN_OPTS} -np $ranks gpurun $command
submit = timeout -s 9 20m mpirun ${MPIRUN_OPTS} -np $ranks gpurun -s $command

#######################################################################

Expand Down Expand Up @@ -102,16 +102,21 @@ PORTABILITY_LIBS = -lm
#submit = mpirun ${MPIRUN_OPTS} -np $ranks $command
#submit = mpirun ${MPIRUN_OPTS} -np $ranks gpurun -s strace -t -e trace=%memory $command
#submit = mpirun ${MPIRUN_OPTS} -np $ranks $command
submit = mpirun ${MPIRUN_OPTS} -np $ranks gpurun -s $command
#submit = timeout 20m mpirun ${MPIRUN_OPTS} -np $ranks $command
submit = timeout -s 9 20m mpirun ${MPIRUN_OPTS} -np $ranks gpurun -s $command
OPTIMIZE += -fopenmp -fopenmp-targets=amdgcn-amd-amdhsa -Xopenmp-target=amdgcn-amd-amdhsa -march=%{gputype}
  OPTIMIZE += -fopenmp-target-xteam-reduction-blocksize=128
OPTIMIZE += -fopenmp-target-xteam-reduction-blocksize=128
# OPTIMIZE += -mcode-object-version=5

505.lbm_t:
505.lbm_t,605.lbm_s,705.lbm_m,805.lbm_l:
OPTIMIZE += -fno-openmp-target-ignore-env-vars
513.soma_t,613.soma_s:
PORTABILITY += -DSPEC_NO_VAR_ARRAY_REDUCE
519.clvleaf_t:
FOPTIMIZE += -Mx,201,2 # workaround for map copy issue
519.clvleaf_t,619.clvleaf_s,719.clvleaf_m,819.clvleaf_l:
FOPTIMIZE += -Mx,201,2 # workaround for map copy issue
# FOPTIMIZE += -Mx,234,100 #
534.hpgmgfv_t:
# COPTIMIZE += -fno-openmp-assume-no-nested-parallelism

%endif

Expand Down
2 changes: 1 addition & 1 deletion test/LLNL/openmp5.0-tests/check_LLNL.sh
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ AOMP_GPU=${AOMP_GPU:-`$AOMP/bin/mygpu`}
export AOMP AOMP_GPU
echo AOMP_GPU = $AOMP_GPU
echo AOMP = $AOMP
date=`date '+%Y-%m-%d'`
date=${BLOG_DATE:-`date '+%Y-%m-%d'`}
if [ "$1" == "log" ]; then
if [ "$2" != "" ]; then
prefix=$2
Expand Down
1 change: 1 addition & 0 deletions test/smoke/managed_memory/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ TESTSRC_ALL = $(TESTSRC_MAIN) $(TESTSRC_AUX)
CLANG ?= clang++
OMP_BIN = $(AOMP)/bin/$(CLANG)
CC = $(OMP_BIN) $(VERBOSE)
RUNENV = HSA_XNACK=1
#-ccc-print-phases
#"-\#\#\#"

Expand Down
8 changes: 8 additions & 0 deletions test/smoke/managed_memory/managed_memory.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,13 @@ int check_res(double * v, int n) {
return err;
}

#ifndef __OFFLOAD_ARCH_gfx90a__
int main() {
printf("This test only works on multi-device MI200 systems (gfx90a).\n");
printf("Existing with pass\n");
return 0;
}
#else
int main() {
int max_devs = omp_get_num_devices();

Expand Down Expand Up @@ -79,3 +86,4 @@ int main() {

return err;
}
#endif

0 comments on commit 5047503

Please sign in to comment.