Custom dates plot ccftime & start of brand new test suite for api.py #101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Reduces length of some lines - Uses only one text delimiter - Adds some spaces around commas
Adds first two full test cases, two tests at least are pending Creates a test suite to test multiple classes.
|
What's the purpose of string comparison in line 47? |
|
to ensure alphabetical sorting of the net.sta names |
heavelock
changed the title
Codecov Report
@@ Coverage Diff @@
## master #101 +/- ##
==========================================
- Coverage 74.28% 73.43% -0.85%
==========================================
Files 17 17
Lines 2477 2477
==========================================
- Hits 1840 1819 -21
- Misses 637 658 +21
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Well, I needed a possibility to plot only a part of data on ccftime plot. Because of that I just decided to add this functionality to the plotting method.
With this occasion I started a test_api test suite and added first few tests to it which are testing methods I modified.
Changes is msnoise_admin are purely PEP8 related.