Refactor NRTM4 Database to emulate WHOIS Database #1579
Conversation
|
Don't duplicate the RIPE database schema in |
...s/src/test/java/net/ripe/db/whois/common/dao/jdbc/AbstractDatabaseHelperIntegrationTest.java
Outdated
Show resolved
Hide resolved
|
|
||
| if (snapshot == null){ | ||
| LOGGER.error("Snapshot cannot be null in the notification file"); | ||
| return Maps.newHashMap(); |
There was a problem hiding this comment.
should this fail? i.e. throw an exception
There was a problem hiding this comment.
well, it is more or less the same that we talked in the office today?
We will retry this in a minute and the error is already in the logs because of the LOGGER.error
| final int version = jsonObject.getInt("version"); | ||
| final String sessionId = jsonObject.getString("session_id"); | ||
| if (!sessionId.equals(updateNotificationFile.getSessionID())) { | ||
| // TODO: [MH] if the service is wrong for any reason...we have here a non-ending loop, we need to |
There was a problem hiding this comment.
I don't know how to resolve it. I put this here to discuss with you
This is risky, I don't want to use the main schema where we are storing all the data for this. |
Correction after discussing: Basically don't copy paste this...we will still use another schema but don't copy paste the .sql |
MiguelAHM
requested review from
fmurodov,
isvonja and
maggarwal13
as code owners
Yes, use the |
No description provided.