Support UTF-8 in RPSL Objects #1576
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…column will need to be converted to utf8 separately (e.g. using MySQL CONVERT).
Conflicts: whois-api/src/main/java/net/ripe/db/whois/api/wsearch/LogSearchService.java whois-client/src/main/java/net/ripe/db/whois/common/rpsl/RpslAttribute.java whois-client/src/test/java/net/ripe/db/whois/common/rpsl/RpslObjectTest.java whois-commons/src/main/java/net/ripe/db/whois/common/rpsl/RpslObjectBuilder.java whois-commons/src/main/resources/pending_schema.sql whois-commons/src/main/resources/scheduler_schema.sql whois-commons/src/main/resources/whois_schema.sql whois-commons/src/test/java/net/ripe/db/whois/common/dao/jdbc/DatabaseHelper.java whois-commons/src/test/java/net/ripe/db/whois/common/support/DummyWhoisClient.java whois-endtoend/src/test/java/net/ripe/db/whois/WhoisFixture.java whois-query/src/test/java/net/ripe/db/whois/query/integration/SimpleTestIntegration.java whois-update/src/main/java/net/ripe/db/whois/update/keycert/PgpPublicKeyWrapper.java whois-update/src/main/java/net/ripe/db/whois/update/keycert/X509CertificateWrapper.java
Conflicts: whois-client/src/test/java/net/ripe/db/whois/common/rpsl/RpslObjectTest.java whois-endtoend/src/test/groovy/net/ripe/db/whois/spec/integration/MailMessageIntegrationSpec.groovy
Conflicts: whois-api/src/test/java/net/ripe/db/whois/api/rest/SyncUpdatesServiceTestIntegration.java whois-api/src/test/java/net/ripe/db/whois/api/rest/WhoisRestServiceTestIntegration.java whois-commons/src/main/resources/whois_schema.sql whois-endtoend/src/test/groovy/net/ripe/db/whois/spec/integration/MailMessageIntegrationSpec.groovy whois-update/src/main/java/net/ripe/db/whois/update/domain/UpdateMessages.java whois-update/src/main/java/net/ripe/db/whois/update/handler/SingleUpdateHandler.java
Ref. "How to support full Unicode in MySQL databases" https://mathiasbynens.be/notes/mysql-utf8mb4 Ref. "In MySQL, never use “utf8”. Use “utf8mb4”." https://medium.com/@adamhooper/in-mysql-never-use-utf8-use-utf8mb4-11761243e434
…e; removed non-existant snapshot_object table; use 'utf8mb4' and not 'utf8'.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change the default character set in RPSL objects from Latin-1 to UTF-8.