Fix clippy issues flagged by latest rust version (backport #13405) #13409
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
* Fix clippy issues flagged by latest rust version This commit fixes 2 issues flagged by running by clippy with Rust 1.82. We run clippy in CI with Qiskit's MSRV of 1.70, as sometimes clippy will flag failures for not using a syntax which isn't compatible with the MSRV. These issues flagged here are real, and good to fix, especially the docstring one, the `////` comment isn't a docstring and that excludes the circuit diagram from the docs which wasn't the intent there. * Remove unnecessary .borrow() call --------- Co-authored-by: Raynel Sanchez <[email protected]> (cherry picked from commit e631685)
mergify
bot
requested review from
alexanderivrii,
ShellyGarion and
a team
as code owners
|
Thank you for opening a new pull request. Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient. While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone. One or more of the following people are relevant to this code:
|
github-actions
bot
added
Changelog: None
Pull Request Test Coverage Report for Build 11740064501Details
💛 - Coveralls |
ElePT
approved these changes
Nov 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This commit fixes 2 issues flagged by running by clippy with Rust 1.82. We run clippy in CI with Qiskit's MSRV of 1.70, as sometimes clippy will flag failures for not using a syntax which isn't compatible with the MSRV. These issues flagged here are real, and good to fix, especially the docstring one, the
////comment isn't a docstring and that excludes the circuit diagram from the docs which wasn't the intent there.Details and comments
This is an automatic backport of pull request #13405 done by [Mergify](https://mergify.com).