Change tox testenv:black envdir #1530
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tansito
approved these changes
Oct 29, 2024
There was a problem hiding this comment.
From my part this looks like a typo from our side but @IceKhan13 has more experience than me with tox.ini so I would wait to merge it until his approval.
Tansito
requested changes
Nov 6, 2024
There was a problem hiding this comment.
@IceKhan13 , @korgan00 just a little comment from @garrison in this PR: Qiskit/qiskit-ibm-catalog#33
I think it's exactly what we are trying to solve in this PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
I realized that if i run
tox -eblack && tox -elintdependencies are installed twice everytime i execute it.If we change the
envdirof black, we have the dependecies duplicated in both directories but they are installed only the first time so it is much faster.Is there any better option @IceKhan13 ?