Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use option --all-targets with clippy check examples and tests #46

Merged
merged 3 commits into from
Jan 17, 2024

Conversation

jlapeyre
Copy link
Collaborator

This commit adds --all-targets to the local CI script as well as the remote CI script. It also fixes several violations found by the change.

This commit adds --all-targets to the local CI script as well as the remote CI
script. It also fixes several violations found by the change.
@jlapeyre
Copy link
Collaborator Author

jlapeyre commented Jan 17, 2024

CI fails because clippy here is apparently a different version from what I run locally.
It would be nice to have a way to keep these in sync.

EDIT: Used toolchain 1.75 locally. This is apparently what is currently used in CI. Found the same errors.

@jlapeyre jlapeyre merged commit 8d761d2 into main Jan 17, 2024
2 checks passed
@jlapeyre jlapeyre deleted the improve-local-CI branch January 23, 2024 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant