Modify the parser to make importing to Qiskit easier or possible #201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The parser no longer is expected to parse bogus gate definitions from stdgates.inc. Rather, symbols are entered as if it had been parsed. This requires modifying how the Qiskit importer works. The main change here is implementing `SymbolTable::gates`. This returns some information on all gates found in the symbol table. Included is the minimal information required for the Qiskit importer to map `SymbolId`s to Qiskit gates. * A smaller convenience: Add GateDeclaration::num_params() for convenience
As noted in a comment, having enum variants `Identifier(Identifier)` where the field is a `struct Identifier` is not necessary, unless we want to carry an extra copy of the name as a `String` for convenience. This is a big price to pay for this convenience, which has not been used for anything. This commit removes `struct Identifier`. This also makes asg.rs more consistent, since some of the variant already have the form `Identifier(SymbolIdResult)`
Looking up symbols has been refactored a bit. A method was added that either returns an existing binding or makes a new one. It always returns a `SymbolId` rather than a `Result<...>`. This method will be used for hardware qubits.
The types of the fields of `Type::Gate` were changed to unsigned.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The parser no longer is expected to parse bogus gate definitions
from stdgates.inc. Rather, symbols are entered as if it had been
parsed. This requires modifying how the Qiskit importer works.
The main change here is implementing
SymbolTable::gates. Thisreturns some information on all gates found in the symbol table.
Included is the minimal information required for the Qiskit importer
to map
SymbolIds to Qiskit gates.Add GateDeclaration::num_params() for convenience
Several other changes are noted in the git commit messages
Expr::Identifier