-
Notifications
You must be signed in to change notification settings - Fork 139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build script and Nexus support for CSCS Piz Daint #4068
base: develop
Are you sure you want to change the base?
Conversation
…ferent name, specifying "format"
Next time. Please always start making a PR by starting from develop to to help keep a clean history. |
Thanks Andrea. I changed the title to be more informative. It makes e.g. writing the release notes much easier. |
Test this please |
@zenandrea ntest_nexus_machines seems failing.
|
I took a look at this and see that it is correctly failing in test_machines.py around line 923. This checks for consistency between the total and per node process counts. The test uses random values that seemingly can't be satisfied the way the Daint machine is current implemented. I suggest to sync with @jtkrogel about what to do here. I don't see another machine with similar logic, so perhaps the test should be revised or some assumptions about how these machine specifications are written needed to be documented.
|
@zenandrea the needed updates to the machines tests can be found the following way:
Use the results printed with this command (and also the full statement bracketed by '''...''' for daint in the non-grepped output) to update the reference table in Following the addition of these lines, |
Head branch was pushed to by a user without write access
This PR should go in. If there are any dangling issues, I will resolve them afterwards. |
Did the Nexus tests ever pass? |
(I have hopefully fixed the conflict correctly. Will see if the CI passes.) |
Test this please |
We can't merge this without either breaking the CI for ~every build or exempting Nexus from testing. Better to fix here. A short write up of how to correctly add a machine would allow me to fix this. |
Please review the developer documentation
on the wiki of this project that contains help and requirements.
Proposed changes
Describe what this PR changes and why. If it closes an issue, link to it here
with a supported keyword.
Added a configuration script for Daint (https://user.cscs.ch/access/running/piz_daint/) in
config/build_cscs_daint.sh
and added daint in the nexus machines
What type(s) of changes does this code introduce?
Delete the items that do not apply
Does this introduce a breaking change?
What systems has this change been tested on?
Daint
Checklist
Update the following with a yes where the items apply. If you're unsure about any of them, don't hesitate to ask. This is
simply a reminder of what we are going to look for before merging your code.