Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Add AI result SR support #260

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

pieper
Copy link
Member

@pieper pieper commented May 28, 2021

This parses specific TID 1500 AI results that contain a rectangle and a score for each detection.

It is fairly special-purpose but make this code a more general than the previous version
that only handled lines. Longer term a more general approach will be needed, probably
by incorporating highdicom as a Slicer dependency.

This parses specific TID 1500 AI results that contain a rectangle and a score for each detection.

It is fairly special-purpose but make this code a more general than the previous version
that only handled lines.  Longer term a more general approach will be needed, probably
by incorporating [highdicom](https://github.com/MGHComputationalPathology/highdicom) as a Slicer dependency.
@pieper pieper requested a review from fedorov May 28, 2021 18:23
@lassoan
Copy link
Collaborator

lassoan commented May 29, 2021

It is great that you use markups line (and not rulers anymore)!

Are you creating a model node for ROIs? We have not markups ROI, which should work much better. It supports automatic and custom (static) measurements with proper DICOM units and terminology support, so with that you can do lossless roundtrip of DICOM import/export, etc. Let me know if you have any questions, or we can discuss at the next developer meeting.

@pieper
Copy link
Member Author

pieper commented May 29, 2021

Yes, we would prefer markup ROIs but there were 1029 boxes in the SR I was working with and that seemed unworkable until this issue is resolved. This is all due for a revamp once we start using highdicom instead of all this manual parsing.

@lassoan
Copy link
Collaborator

lassoan commented May 29, 2021

As a quick workaround, we could turn off interaction and always (or never) show labels, so that we don't need to keep querying the z buffer. I've asked @Sunderlandkyl to investigate. It would be really bad if after all the invested efforts, markups could not be used because of this performance problem.

@fedorov
Copy link
Member

fedorov commented Jun 7, 2021

@Sunderlandkyl any updates?

@fedorov
Copy link
Member

fedorov commented Jun 7, 2021

@pieper does it make sense to consider support of those planar annotation types in this PR as well: OHIF/Viewers#1215 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants