Skip to content

Commit

Permalink
Make parent formid a part of autorenerated oid
Browse files Browse the repository at this point in the history
  • Loading branch information
ezag committed Jun 11, 2021
1 parent f8529d8 commit 6863f9d
Show file tree
Hide file tree
Showing 3 changed files with 22 additions and 2 deletions.
3 changes: 2 additions & 1 deletion deform/field.py
Original file line number Diff line number Diff line change
Expand Up @@ -187,7 +187,6 @@ def __init__(
):
self.counter = counter or itertools.count()
self.order = next(self.counter)
self.oid = getattr(schema, "oid", "deformField%s" % self.order)
self.schema = schema
self.typ = schema.typ # required by Invalid exception
self.name = schema.name
Expand Down Expand Up @@ -225,6 +224,8 @@ def __init__(
if parent is not None:
parent = weakref.ref(parent)
self._parent = parent
oid_prefix = getattr(self.get_root(), "formid", "deform")
self.oid = getattr(schema, "oid", f"{oid_prefix}Field{self.order}")
self.__dict__.update(kw)

first_input_index = -1
Expand Down
2 changes: 1 addition & 1 deletion deform/form.py
Original file line number Diff line number Diff line change
Expand Up @@ -139,6 +139,7 @@ def __init__(
# Use kwargs to pass flags to descendant fields; saves cluttering
# the constructor
kw["focus"] = self.focus
self.formid = formid
field.Field.__init__(self, schema, **kw)
_buttons = []
for button in buttons:
Expand All @@ -148,7 +149,6 @@ def __init__(
self.action = action
self.method = method
self.buttons = _buttons
self.formid = formid
self.use_ajax = use_ajax
self.ajax_options = Markup(ajax_options.strip())
form_widget = getattr(schema, "widget", None)
Expand Down
19 changes: 19 additions & 0 deletions deform/tests/test_form.py
Original file line number Diff line number Diff line change
Expand Up @@ -162,6 +162,25 @@ def test_issue_71(self):
1,
)

def test_issue_394(self):
# Pyramid
import colander

# Deform
import deform

class FooForm(colander.Schema):
foo_field = colander.SchemaNode(colander.String())

class BarForm(colander.Schema):
bar_field = colander.SchemaNode(colander.String())

foo_form = deform.Form(FooForm(), formid="fooForm")
bar_form = deform.Form(BarForm(), formid="barForm")
self.assertNotEqual(
foo_form["foo_field"].oid, bar_form["bar_field"].oid
)


class TestButton(unittest.TestCase):
def _makeOne(self, **kw):
Expand Down

0 comments on commit 6863f9d

Please sign in to comment.