Add better exception handling in transition list input - in particular make the FileModifiedException more informative #3202
Conversation
…r make the FileModifiedException more informative
| @@ -1509,6 +1509,17 @@ public SrmDocument ImportMassList(MassListInputs inputs, | |||
| Replace(TextUtil.SEPARATOR_TSV_STR, @" "); | |||
| errorList.Add(new TransitionImportErrorInfo(x.PlainMessage, x.ColumnIndex, x.LineNumber + 1, line)); // CONSIDER: worth the effort to pull row and column info from error message? | |||
| } | |||
| catch (Exception ex) | |||
There was a problem hiding this comment.
I don't think this is the right place to put this. This is supposed to be for issues with parsing a line, not for global errors. You should be catching other exceptions higher up the callstack.
There was a problem hiding this comment.
Catching it here is advantageous as it ties into the reporting mechanism for both the UI and commandline use cases.
| @@ -1544,6 +1555,17 @@ public SrmDocument ImportMassList(MassListInputs inputs, | |||
| { | |||
| errorList.Add(new TransitionImportErrorInfo(x)); | |||
| } | |||
| catch (Exception ex) | |||
There was a problem hiding this comment.
I don't think this is the right place to put this. This is supposed to be for issues with parsing a line, not for global errors. You should be catching other exceptions higher up the callstack.
There was a problem hiding this comment.
Catching it here is advantageous as it ties into the reporting mechanism for both the UI and commandline use cases.
…in_associate_proteins
…in_associate_proteins
…in_associate_proteins
|
@brendanx67 do you still want to change this? I could add two sets of error handling (UI and commandline) if you feel strongly about it. |
…in_associate_proteins
In response to https://skyline.ms/announcements/home/issues/exceptions/thread.view?entityId=96760a55-6efc-103d-a666-22f53556a042&_anchor=66300
I don't have a repro for the problem, unfortunately