Update MBI SDK and enable in Skyline #3200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* deleted now unnecessary HDF5 headers * added new MBI test file with CCS calibration * added combineIonMobilitySpectra option for msbenchmark * uncommented Mobilion support in Skyline
* updated MBI file format and nativeID cvParam
…needed because CV update with new Thermo instruments would break tests that make sure instrument configurations are populated for all Thermo instruments) * fixed Reader_Mobilion getCvType()
…obility() - added zero bounding for Mobilion profile data (required for CWT peak picking; can be disabled with --ignoreZeroIntensityPoints)
…obilion combined IMS spectra - fixed peakPicking filter non-vendor centroiding warning to mention lack of support for Waters and Agilent IMS centroiding, and removed redundant message specific to Waters * fixed a few compile warnings
…opening multiple MBI files (e.g. MSConvertGUI converting in parallel) * changed VendorReaderTestHarness to use temporary filepaths with random strings for mz5/mzMLb testing (needed to re-enable testThreadSafety() there to test the process-wide mutex changes, though I still leave that commented out)
…CS values outside the calibrated range
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
updated MBI reader with version that hides HDF5 dependency
deleted now unnecessary HDF5 headers
added new MBI test file with CCS calibration
added combineIonMobilitySpectra option for msbenchmark
uncommented Mobilion support in Skyline