Optimize for size #185
Optimize for size #185
Conversation
csware
force-pushed
the
optimize-for-size
branch
from
30ddf5c
to
cc6d505
Compare
|
Personally I would choose speed over size. I believe most other users too. I don't think optimizing for speed over size alone is what is making our builds so much larger (#183). Default configuration should be optimizing for speed. |
|
Is it normal that GitHub shows diff in this PR with already merged master as if it wasn't merged? Supposedly it should only show new changes in this PR compared to new HEAD. |
This saves around 300 KiB w/o boost. Signed-off-by: Sven Strickroth <[email protected]>
This saves another 200 KiB, however, this now requires the MSVC++ to be present. Notepad2 was also linked against this runtime library (requires the old MSVCP60.DLL). Signed-off-by: Sven Strickroth <[email protected]>
csware
force-pushed
the
optimize-for-size
branch
from
cc6d505
to
8a40f49
Compare
Please clarify: what is supposed to be done with the changes from this PR? |
|
@csware What are we supposed to do with this PR? |
|
Yesterday I build the vanilla Notepad2 sources (with VS2017) and got a binary of ~800kib, building bf22e43 alrteady resulted in ~1,2mib (x86). |
Could you figure why? Maybe because of the updated Scintilla? Or VC runtime version? Personally I don't mind the extra 1.5 MiB of size Notepad 2e brings. It's almost completely irrelevant in today's world, it's not like we're talking about 10s or 100s of megabytes gained. If there's an easy way to shed off some size without sacrificing functionality (Boost, etc.) or speed, then it's fine, but if not, I would not stress too much over it. |
I wonder if it's a coincidence that XhmikosR's mod (https://github.com/XhmikosR/notepad2-mod/) is about the same size, 1.38 MB. |
This improves issue #183. However, I suppose you/we want to discuss comit 30ddf5c as this introduces a new dependency to the VS2017 C++ Runtime Libraries (which are not present on all Windows systems by default, IIRC).
This MR is supposed to be on top of #184.