Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add internal async_dispatch util #15813

Merged
merged 3 commits into from
Nov 4, 2024
Merged

add internal async_dispatch util #15813

merged 3 commits into from
Nov 4, 2024

Conversation

zzstoatzz
Copy link
Collaborator

@zzstoatzz zzstoatzz commented Oct 25, 2024 •
edited
Loading

related to #15008

@zzstoatzz zzstoatzz self-assigned this Oct 25, 2024
@zzstoatzz zzstoatzz added the development Tech debt, refactors, CI, tests, and other related work. label Oct 25, 2024
@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Oct 25, 2024 •
edited
Loading

CodSpeed Performance Report

Merging #15813 will not alter performance

Comparing async-compatible (5b9bce8) with main (ab964c1)

Summary

✅ 3 untouched benchmarks

cicdw
cicdw reviewed Oct 28, 2024
View reviewed changes
Copy link
Member

@cicdw cicdw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small big suggestion for consideration, otherwise makes sense to me

src/prefect/_internal/compatibility/async_compatible.py Outdated Show resolved Hide resolved
@zzstoatzz zzstoatzz marked this pull request as ready for review November 1, 2024 14:44
@zzstoatzz zzstoatzz changed the title add internal async_compatible util add internal async_dispatch util Nov 1, 2024
desertaxle
desertaxle approved these changes Nov 4, 2024
View reviewed changes
Copy link
Member

@desertaxle desertaxle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@zzstoatzz zzstoatzz merged commit 2457810 into main Nov 4, 2024
36 checks passed
@zzstoatzz zzstoatzz deleted the async-compatible branch November 4, 2024 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@desertaxle desertaxle desertaxle approved these changes

@chrisguidry chrisguidry Awaiting requested review from chrisguidry

@cicdw cicdw Awaiting requested review from cicdw cicdw is a code owner

Assignees

@zzstoatzz zzstoatzz

Labels
development Tech debt, refactors, CI, tests, and other related work.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zzstoatzz @desertaxle @cicdw