Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add seccompProfile as valid podSecurityContext property #375

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

dk-oc
Copy link

@dk-oc dk-oc commented Aug 27, 2024

Looking at the chart i saw that only the allowed values prohibit setting seccompProfile.

This would fix: #374

@dk-oc dk-oc requested a review from a team as a code owner August 27, 2024 09:43
@@ -313,6 +313,16 @@
"type": "integer",
"title": "FS Group",
"description": "set server pod's security context fsGroup"
},
"seccompProfile": {
"type": "object",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is additionalProperties defaulting to true here (eg. if you need to pass localhostProfile)? or do we need to explicitly set it here?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @dk-oc - just following up here.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry I missed the notification.
As far as I understand it defaults to true if a podSecurityContext is set.
I use a values.yml as such and can deploy the chart in the restricted environment I am running

server:
  containerSecurityContext:
    capabilities:
      drop: ["ALL"]
  podSecurityContext:
    seccompProfile:
      type: RuntimeDefault

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dk-oc - I believe the question was more about what happens if you set type: Localhost, as that one requires an extra field to be set named localhostProfile:

securityContext:
  seccompProfile:
    type: Localhost
    localhostProfile: my-profiles/profile-allow.json

We'd need to either set additionalProperties here, or explicitly define the localhostProfile

@jamiezieziula
Copy link
Contributor

@dk-oc going to close this PR for now. Feel free to reopen in the future.

@dk-oc
Copy link
Author

dk-oc commented Oct 4, 2024

@dk-oc going to close this PR for now. Feel free to reopen in the future.

It seems I can not reopen this PR I could only create a new one.

@mitchnielsen mitchnielsen reopened this Oct 4, 2024
@mitchnielsen
Copy link
Contributor

I reopened it for ya @dk-oc 👍🏼

@dk-oc
Copy link
Author

dk-oc commented Oct 15, 2024

@mitchnielsen Thank you.
Is there anything missing in this PR which hinders a merging?

@mitchnielsen
Copy link
Contributor

Thanks for checking in @dk-oc, I missed the added commits. I took a look and left a comment in the thread above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow to set podSecurityContext seccompProfile
4 participants