Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conditional imports to support operating with pydantic>2 installed #60

Merged
merged 1 commit into from
Oct 4, 2023

Conversation

chrisguidry
Copy link
Contributor

Following the compatibility work we've done in prefect, we also want to apply the
same compatibility changes to all Prefect-maintained collections. We're following the
convention that Prefect will always use pydantic<2 idioms, leaning on the
pydantic.v1 module of pydantic>2 to aid us in this. With these changes, we can
operate normally regardless of the installed version.

Until prefect fully deprecates pydantic versions below 2.0, we'll continue to
maintain that constraint of using only v1 idioms.

This is part of a series of identical PRs for all of our maintained collections.

@chrisguidry chrisguidry requested a review from a team as a code owner October 4, 2023 18:07
Copy link
Contributor

@zzstoatzz zzstoatzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧙🏼‍♂️

@chrisguidry chrisguidry merged commit d1760bb into main Oct 4, 2023
5 checks passed
@chrisguidry chrisguidry deleted the pydantic-v2-compatibility branch October 4, 2023 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants