S3 Backend: load keys from file with automatic reload #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahouene
force-pushed
the
minio-k8s-credentials
branch
from
9e8244f
to
961f462
Compare
wojas
reviewed
Sep 5, 2023
backends/s3/credentials.go
Outdated
| type K8sSecretProvider struct { | ||
| // Path to the fiel containing the access key, | ||
| // e.g. /etc/s3-secrets/access-key. | ||
| AccessKeyFilename string `json:"access_key_file"` |
There was a problem hiding this comment.
JSON name does not match the variable name. In this case it would commonly be called access_key_filename, or the variable named AccessKeyFile. There is no good reason to deviate from this pattern here.
ahouene
changed the title
wojas
reviewed
Sep 7, 2023
wojas
reviewed
Sep 7, 2023
|
|
||
| stop := func() error { | ||
| _ = cmd.Process.Signal(os.Interrupt) | ||
| return cmd.Wait() |
There was a problem hiding this comment.
This could hang forever if the context does not have a timeout.
|
The PR description mentions |
wojas
reviewed
Sep 7, 2023
wojas
reviewed
Sep 12, 2023
wojas
reviewed
Sep 12, 2023
wojas
reviewed
Sep 14, 2023
Co-authored-by: wojas <[email protected]>
|
LGTM Tested this PR in 2 applications in a Kubernetes deployment and both worked as expected: Cycling the access/secret keys in the Secret leads to Simpleblob picking up the updated credentials once the Secret is synced to the filesystem of the container. |
nvaatstra
approved these changes
Sep 14, 2023
wojas
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce a
github.com/minio/minio-go/v7/pkg/credentials.Providerimplementation, accepting credentials split accross different files as with Kubernetes Secrets or Docker Secrets.This way, the backend can get its S3 credentials with a configuration similar to:
{ "access_key_file": "/etc/secret-volume/access-key", "secret_key_file": "/etc/secret-volume/secret-key" }