Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat(postgresql): Add support for postgresql backend (including tests) #211

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Exchizz
Copy link

@Exchizz Exchizz commented Apr 1, 2024

Hi,

I have a use case where I would like to use postgressql as a backend for pdns.

This PR finishes the work started by #104

I've made the following changes:

  • Minor changes to add pgsql backend #104

  • Add tests to the postgresSQL ansible code (I've added tests similar to what is tested with MySQL backend)

    • Added a PostgreSQL service to test creation of postgresql user/database/schemas
  • Added "throttle:1" to both MySQL and PostgreSQL user creation module. Occasionally the tasks failed and I'm assuming it's because of race-conditions. (For both MySQL and PostgreSQL, a user with the same name is created multiple times (foreach distro in the tests) and assigned permissions/privileges)

  • Added support for PostgreSQL's Host Based Authentication. This can be used when PowerDNS Authoritative server is installed on the same host as the PostgreSQL server. In that case, Ansible does not need a privileged PostgreSQL user to create a user for PowerDNS. It will simply use the unix socket and use become "postgresql". This is unfortunately not covered by any tests.

@Exchizz Exchizz force-pushed the feat/add-support-for-postgressql-backend branch from 212161f to ec65eb5 Compare April 1, 2024 13:52
@Exchizz Exchizz changed the title Feat(postgresql): Add support for postgresql backend (including tests) Feat(postgresql): Add support for postgresql backend (including tests) + fix bug with arch linux that causes scheduled actions to fail Apr 1, 2024
@Exchizz Exchizz marked this pull request as ready for review April 1, 2024 14:24
@Exchizz Exchizz mentioned this pull request Apr 1, 2024
@Exchizz Exchizz marked this pull request as draft April 3, 2024 09:07
@Exchizz Exchizz marked this pull request as ready for review April 4, 2024 08:31
@commonism
Copy link

You could have kept my commit.
To me this is borderline copyright infringement.

@birjj

This comment was marked as off-topic.

@Exchizz Exchizz force-pushed the feat/add-support-for-postgressql-backend branch from bda11f8 to d0181ef Compare April 6, 2024 20:47
@Exchizz
Copy link
Author

Exchizz commented Apr 6, 2024

Hi @commonism,

Done

@commonism
Copy link

@commonism Your contribution is licensed under the MIT license. It explicitly allows merging code without attribution.

I thought this was MIT-0, but well, can you point me to somewhere to read up on this?

You can discuss open source etiquette if you want, but legalities have nothing to do with it.

He's settled things already.

@birjj

This comment was marked as off-topic.

@commonism
Copy link

MIT-0 is "zero attribution", the license here is MIT.
I was not aware MIT can be read as merge-without-attribution as well and was asking for an explanation of this.

@birjj
Copy link

birjj commented Apr 8, 2024

@commonism I've created a discussion in a throwaway repo to continue the license talk - there's no need to spam this PR with irrelevant discussion (open source etiquette and all 😉)

@Exchizz Exchizz force-pushed the feat/add-support-for-postgressql-backend branch from d0181ef to f6c7093 Compare April 15, 2024 09:00
@Exchizz Exchizz changed the title Feat(postgresql): Add support for postgresql backend (including tests) + fix bug with arch linux that causes scheduled actions to fail Feat(postgresql): Add support for postgresql backend (including tests) Apr 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants