Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor sleep and loop #232

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jacobrosenthal
Copy link
Contributor

We were keeping sleep state in several different places
sleepUntilMatch could return a boolean locally which was unused
local state was actually held in timer_match
then scheduledticks could be called to return if there were ticks left

Ive collapsed these keeping the timer_match as the internal class state variable.
For external scheduledticksleft() still exists, but is returned from dosleep so should never need to be called

The result is that scout can simplify sleepPending handling greatly.

Besides being better, I think Ill be persuing a state machine instead of booleans to control sleep state especially as I look at adding radio sleep to synchronize between scouts.

also theres a bunch of led indication stuff cluttering up the loop Id like to move out to an led handling function

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant