Create contributors guide #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthieucan
commented
Jun 6, 2024
Comment on lines
-13
to
+14
| ```shell | ||
| $ dbt-score lint | ||
| ``` | ||
| > dbt-score lint |
There was a problem hiding this comment.
With shell, the numbers appear in red, which is quite confusing as it's not the case in the actual terminal output
There was a problem hiding this comment.
It is, good change 👌
| @@ -81,10 +81,10 @@ Every rule can be configured with the following option: | |||
| of 4. | |||
|
|
|||
| Some rules have additional configuration options, e.g. | |||
| [sql_has_reasonable_number_of_lines](/rules/generic/#sql_has_reasonable_number_of_lines). | |||
| [sql_has_reasonable_number_of_lines](rules/generic.md#sql_has_reasonable_number_of_lines). | |||
There was a problem hiding this comment.
Great, I noticed these links as well 👌
docs/contributors_guide.md
Outdated
|
|
||
| ### Adding or changing core features | ||
|
|
||
| Before implementing or changing a new feature, we kindly ask you to |
There was a problem hiding this comment.
I think we mention a lot of times that they should always open an issue first, becomes a little bit too much IMO
Comment on lines
-13
to
+14
| ```shell | ||
| $ dbt-score lint | ||
| ``` | ||
| > dbt-score lint |
There was a problem hiding this comment.
It is, good change 👌
druzhinin-kirill
approved these changes
Jun 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While there, fix some inconsistencies in the documentation website, and update the readme.