Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] Small addition of a function to save descriptors as a numpy array from the Calculator API #15

Merged
merged 5 commits into from
Mar 17, 2024

Conversation

ricardonpa
Copy link
Contributor

No description provided.

@amkrajewski amkrajewski self-requested a review March 13, 2024 21:19
@amkrajewski
Copy link
Contributor

Hi @rdamaral ! Thanks for the PR. Could you add at least a runtime test to our suite? Ideally, make it bidirectional.

@amkrajewski
Copy link
Contributor

Copy link

codecov bot commented Mar 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.84%. Comparing base (db97b94) to head (74a31dd).

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #15      +/-   ##
==========================================
+ Coverage   94.79%   94.84%   +0.05%     
==========================================
  Files          17       17              
  Lines        1977     1999      +22     
==========================================
+ Hits         1874     1896      +22     
  Misses        103      103              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@amkrajewski
Copy link
Contributor

@rdamaral Almost there! We need to test the default destination persistence, too. Have a look at uncovered lines on Codecov report above :)

Copy link
Contributor

@amkrajewski amkrajewski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! It's ready to be merged.

@amkrajewski amkrajewski merged commit ba1755b into PhasesResearchLab:main Mar 17, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants