Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sort hash keys #6

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Sort hash keys #6

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
573a2c6
Sort hash keys
bmwiedemann Sep 18, 2017
0882448
Sort find_file file list
bmwiedemann Jun 19, 2019
040f4c9
Enforce list context for the return value of sort
perlpunk Apr 28, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions inc/My/Builder/Unix.pm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ sub get_additional_cflags {
my $self = shift;
my @list = ();
### any platform specific -L/path/to/libs shoud go here
for (keys %$inc_lib_candidates) {
for (sort keys %$inc_lib_candidates) {
push @list, "-I$_" if (-d $_);
}
return join(' ', @list);
Expand All @@ -36,7 +36,7 @@ sub get_additional_libs {
$rv{"-Wl,-rpath,$ld"} = 1 if $^O =~ /^linux|dragonfly|.+bsd$/;
}
}
push @list, (keys %rv);
push @list, sort (keys %rv);
if ($^O eq 'openbsd') {
my $osver = `uname -r 2>/dev/null`;
if ($self->notes('perl_libs')->{pthread} || ($osver && $osver < 5.0)) {
Expand Down
2 changes: 1 addition & 1 deletion inc/My/Utility.pm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -477,7 +477,7 @@ sub find_file {
no warnings;
find({ wanted => sub { push @files, rel2abs($_) if /$re/ }, follow => 1, no_chdir => 1 , follow_skip => 2}, $dir);
};
return @files;
return @files = sort @files; # enforce list context, see `perldoc -f sort`
}

sub find_SDL_dir {
Expand Down