Handle fluent getters for primitive return types #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DenWav
requested changes
Jul 27, 2023
src/main/java/io/papermc/codebook/lvt/LvtAssignmentSuggester.java
Outdated
Show resolved
Hide resolved
Machine-Maker
force-pushed
the
fluent-getters
branch
from
b079b1f
to
e65b7bc
Compare
DenWav
reviewed
Jul 28, 2023
|
|
||
| // 3 instructions, load "this" local var, getfield, return - TODO maybe if there is a CAST, | ||
| private static final IntPredicate[] OPCODES_IN_ORDER = new IntPredicate[] { | ||
| i -> i == Opcodes.ALOAD, i -> i == Opcodes.GETFIELD, i -> i >= Opcodes.IRETURN && i <= Opcodes.RETURN |
There was a problem hiding this comment.
ALOAD should always be of slot 0 for this.
There was a problem hiding this comment.
Do you mean that I should be checking more than just the opcode in these predicates? that I should also check the slot of the var insn here?
src/main/java/io/papermc/codebook/lvt/LvtAssignmentSuggester.java
Outdated
Show resolved
Hide resolved
Machine-Maker
force-pushed
the
fluent-getters
branch
2 times, most recently
from
33a63bb
to
d3b62c0
Compare
DenWav
force-pushed
the
main
branch
3 times, most recently
from
990ed71
to
7b5923e
Compare
Machine-Maker
force-pushed
the
fluent-getters
branch
3 times, most recently
from
53e9d67
to
8408ccb
Compare
|
Updated for modular suggester system |
Machine-Maker
force-pushed
the
fluent-getters
branch
from
8408ccb
to
2bbee6c
Compare
|
needs to skip intValue, booleanValue...., plus get maybe we can even ignore the autoboxing and use the "inner" method? or we special case block state properties |
MiniDigger
force-pushed
the
fluent-getters
branch
from
2bbee6c
to
a37a170
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checks if the method has a primitive return type, and if the instructions with opcodes in the method follow a specific order and type so as to indicate it is a simple getter.