handle 'should'

PaperMC · Jul 26, 2023 · acfc00b · acfc00b
1 parent b69ad96
commit acfc00b
Showing 1 changed file with 4 additions and 2 deletions.
diff --git a/src/main/java/io/papermc/codebook/lvt/LvtAssignmentSuggester.java b/src/main/java/io/papermc/codebook/lvt/LvtAssignmentSuggester.java
@@ -41,7 +41,7 @@ private LvtAssignmentSuggester() {}
             return suggested;
         }
 
-        suggested = suggestNameFromIsOrHas(methodName, insn);
+        suggested = suggestNameFromVerbBoolean(methodName, insn);
         if (suggested != null) {
             return suggested;
         }
@@ -110,7 +110,7 @@ public static String suggestNameFromRecord(final String methodName) {
         }
     }
 
-    private static @Nullable String suggestNameFromIsOrHas(final String methodName, final MethodInsnNode insn) {
+    private static @Nullable String suggestNameFromVerbBoolean(final String methodName, final MethodInsnNode insn) {
         if (insn.desc == null || !insn.desc.endsWith("Z")) { // only handle methods that return booleans
             return null;
         }
@@ -122,6 +122,8 @@ public static String suggestNameFromRecord(final String methodName) {
             prefix = "has";
         } else if (!"can".equals(methodName) && methodName.startsWith("can")) {
             prefix = "can";
+        } else if (!"should".equals(methodName) && methodName.startsWith("should")) {
+            prefix = "should";
         } else {
             return null;
         }