-
Notifications
You must be signed in to change notification settings - Fork 13.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Support for DroneCAN Status Extended Message #23896
base: main
Are you sure you want to change the base?
Add Support for DroneCAN Status Extended Message #23896
Conversation
…tatus extended message
You need to use Instead remove the msg that is just an array and create a publication multi handle member var. Don't use a member var for the status data. |
also maybe add to the high_rate set in logged_topics.cpp |
Ah, got it, sorry! I had understood the PublicationMulti as, "There are multiple modules in PX4 who are going to be publishing to this topic," and not necessarily multiple devices that need their own publishers. I think I was just confusing myself by thinking that you might want DSHOT telemetry as well as DroneCAN telemetry at the same time, so you'd have 2 ESC Status reporters. Regardless, I get it now, and will make those changes! |
…nnecessary messge type
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nitpicky but I would make this less verbose, just makes it slightly easier to read
This is the Status Extended portion of a prior PR discussed with @dakejahl here #23882. He has handled the Node Status portion in his own PR here: #23890.
Attached is a log where you can see the ESC Status Extended logging.
log_1_2024-11-5-10-08-06.zip
Here's a quick snapshot of the input/output throttle percentages from 3 attached ESCs. One motor is configured purposefully so that the input and output throttles should not match.