Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(mis): 修复系统初始化时作业价格表设置页面报错问题 #1350

Merged
merged 2 commits into from
Jul 10, 2024

Conversation

piccaSun
Copy link
Contributor

@piccaSun piccaSun commented Jul 9, 2024

问题

系统初始化时 作业价格表设置页面 因集群排序参数为空数组报错
原因为管理系统集群排序列表的上下文context的获取逻辑中集群配置信息数据为{ }时也可以获取排序结果为[ ]

同时此PR在getClustersRuntimeInfogetSimpleClustersInfoRomConfigFiles中增加了403的返回,
修改了mis-web启动时因token过期等情况validation(token)验证没有通过导致api请求挂起的警告
image

修改后

相关api请求正常返回403
image

若是已初始化系统启动时
portal正常启动:
image
mis正常启动:
image

若是未初始化系统启动时, 与集群、集群优先级排序数组相关数据获取正常
image
image
image
image

Copy link

changeset-bot bot commented Jul 9, 2024

🦋 Changeset detected

Latest commit: 81e4c11

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 12 packages
Name Type
@scow/mis-web Patch
@scow/config Patch
@scow/lib-web Patch
@scow/lib-server Patch
@scow/ai Patch
@scow/audit-server Patch
@scow/auth Patch
@scow/cli Patch
@scow/mis-server Patch
@scow/portal-server Patch
@scow/portal-web Patch
@scow/gateway Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@piccaSun piccaSun changed the title fix(mis): 修复系统初始化时作业价格表设置页面报错问题 fix(mis): 修复系统初始化时作业价格表设置页面报错问题 Jul 9, 2024
@piccaSun piccaSun marked this pull request as ready for review July 10, 2024 00:35
@pkuhpc-review-bot pkuhpc-review-bot bot added the Code-ReviewRequested Code Review Requested label Jul 10, 2024
@pkuhpc-review-bot pkuhpc-review-bot bot requested a review from ddadaal July 10, 2024 00:35
@piccaSun piccaSun marked this pull request as draft July 10, 2024 00:53
@piccaSun piccaSun force-pushed the fix-initial-sysytem-sorted-clusterIds branch from 2a04422 to 81e4c11 Compare July 10, 2024 03:07
@piccaSun piccaSun marked this pull request as ready for review July 10, 2024 05:57
@pkuhpc-review-bot pkuhpc-review-bot bot added Code-Approved Code Review approved ReadyForMerge Ready for merge and removed Code-ReviewRequested Code Review Requested labels Jul 10, 2024
@ddadaal ddadaal merged commit 0eb668d into master Jul 10, 2024
9 checks passed
@ddadaal ddadaal deleted the fix-initial-sysytem-sorted-clusterIds branch July 10, 2024 12:13
OYX-1 pushed a commit that referenced this pull request Jul 11, 2024
### 问题

系统初始化时 作业价格表设置页面 因集群排序参数为空数组报错
原因为管理系统集群排序列表的上下文context的获取逻辑中集群配置信息数据为{ }时也可以获取排序结果为[ ]

同时此PR在`getClustersRuntimeInfo`
和`getSimpleClustersInfoRomConfigFiles`中增加了403的返回,
修改了mis-web启动时因token过期等情况validation(token)验证没有通过导致api请求挂起的警告

**![image](https://github.com/PKUHPC/SCOW/assets/43978285/01ed6772-1258-441d-9243-49300afb1673)**

### 修改后
相关api请求正常返回403

![image](https://github.com/PKUHPC/SCOW/assets/43978285/ba399c02-374a-4324-8f8c-e79533bf91ce)

若是已初始化系统启动时
portal正常启动:

![image](https://github.com/PKUHPC/SCOW/assets/43978285/54bbec20-4f90-4510-b37a-caa2cf5fbd5c)
mis正常启动:

![image](https://github.com/PKUHPC/SCOW/assets/43978285/0e878523-82b1-4cca-bcd6-17df683ae45c)

若是未初始化系统启动时, 与集群、集群优先级排序数组相关数据获取正常

![image](https://github.com/PKUHPC/SCOW/assets/43978285/dc81fa06-f6a2-469d-b778-e174b2cf33c3)

![image](https://github.com/PKUHPC/SCOW/assets/43978285/200e4d47-1d9f-4c12-8bcb-dd5b930bdd41)

![image](https://github.com/PKUHPC/SCOW/assets/43978285/01e58a5a-ae75-403b-96b7-35977800b3a8)

![image](https://github.com/PKUHPC/SCOW/assets/43978285/c9901152-1e71-4b9e-8255-09fc3985b90e)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code-Approved Code Review approved ReadyForMerge Ready for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants