filledcurves with above/below threshold and fillcolor implemented. #105
+45
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mohawk2
requested changes
Nov 16, 2024
| $x, ($x)**3 | ||
| ); | ||
| prompt("Area curve with filled colors"); | ||
|
|
There was a problem hiding this comment.
Can you drop this blank line? Thanks.
lib/PDL/Graphics/Gnuplot.pm
Outdated
| @@ -5266,7 +5300,8 @@ our $cOptionsAbbrevs = _gen_abbrev_list(keys %$cOptionsTable); | |||
| lc => ["linecolor"], | |||
| pt => ["pointtype"], | |||
| ps => ["pointsize"], | |||
| fs => ["fillstyle"] | |||
| fs => ["fillstyle"], | |||
| fc => ["fillcolor"] | |||
There was a problem hiding this comment.
Can you please add a , on the end, so one could add another line here without spurious diffs, given Perl allows that?
Pull Request Test Coverage Report for Build 11861464356Details
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
example added as well. tested and it works.