Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PDBE-6103 #7

Merged
merged 7 commits into from
May 16, 2024
Merged

PDBE-6103 #7

merged 7 commits into from
May 16, 2024

Conversation

Joseph-Ellaway
Copy link
Collaborator

Updated the dendrogram-rendering code to lower the position of the x-axis and extend the leaf cluster labels.

This is needed for clusters with high similarity, which are positioned very low on the plot. When their scores are close to zero (low dissimilarity), the horizontal line connecting the node is obscured behind the x-axis.

No core functionality has been changed, only the appearance of rendered dendrograms.

Before:
O34926_agglomerative_dendrogram

After:
O34926_agglomerative_dendrogram_new

@Joseph-Ellaway
Copy link
Collaborator Author

Closed due to scope of feature PDBE-6103 being extended. File names of dendrograms should be saved with UNP start and end positions included.

It is now possible to parse in a residue range (possibly UniProt) into the application. This now affects the file name of the dendrogram, if rendered. If the residue IDs are not specified, behaviour reverts to normal
@Joseph-Ellaway
Copy link
Collaborator Author

Capability to add UniProt sequence start and end positions enabled. This is optional, therefore non-breaking change.

@sreenathnair sreenathnair merged commit c2e12ed into main May 16, 2024
3 checks passed
@Joseph-Ellaway Joseph-Ellaway deleted the PDBE-6103 branch June 10, 2024 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants